Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-orgs: Add Arrikto team #401

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

yanniszark
Copy link
Contributor

Add Arrikto team to GitHub orgs so they can all be mentioned easily with
@kubeflow/arrikto.

/cc @Bobgy @jlewi

BTW, I found this similar file in kubeflow/community: https://github.com/kubeflow/community/blob/master/member_organizations.yaml

Is it deprecated, or should I update that as well?

Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com

@k8s-ci-robot
Copy link

@yanniszark: GitHub didn't allow me to request PR reviews from the following users: jlewi.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Add Arrikto team to GitHub orgs so they can all be mentioned easily with
@kubeflow/arrikto.

/cc @Bobgy @jlewi

BTW, I found this similar file in kubeflow/community: https://github.com/kubeflow/community/blob/master/member_organizations.yaml

Is it deprecated, or should I update that as well?

Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add Arrikto team to GitHub orgs so they can all be mentioned easily with
@kubeflow/arrikto.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@Bobgy
Copy link
Contributor

Bobgy commented Nov 12, 2020

/lgtm
/approve

I don't have much context about https://github.com/kubeflow/community/blob/master/member_organizations.yaml, asking about it now.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b4af365 into kubeflow:master Nov 12, 2020
@theadactyl
Copy link

I believe that file was there less to offer explicit permins, and more to allow community members to note their involvement in the project. That being said, it's never been widely used and should probably be deprecated. @yanniszark or @Bobgy would either of you want to make a proposal to that effect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants