Skip to content

Commit

Permalink
Fixes lint warnings in YAML files (#1902)
Browse files Browse the repository at this point in the history
* Fix missing document start warnings

* Fix too few spaces before comment warning
  • Loading branch information
Rishit-dagli committed Jun 22, 2022
1 parent 04ac975 commit 7bf3922
Show file tree
Hide file tree
Showing 76 changed files with 77 additions and 1 deletion.
1 change: 1 addition & 0 deletions examples/v1beta1/argo/argo-workflow.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This example shows how you can use Argo Workflows in Katib, transfer parameters from one Step to another and run HP job.
# It uses a simple random algorithm and tunes only learning rate.
# Workflow contains 2 Steps, first is data-preprocessing second is model-training.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This is example with median stopping early stopping rule with logs in JSON format.
# It has bad feasible space for learning rate to show more early stopped Trials.
apiVersion: kubeflow.org/v1beta1
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/early-stopping/median-stop.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This is example with median stopping early stopping rule.
# It has bad feasible space for learning rate to show more early stopped Trials.
apiVersion: kubeflow.org/v1beta1
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/bayesian-optimization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/cma-es.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/grid.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/hyperband.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/multivariate-tpe.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/random.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/simple-pbt.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/sobol.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/hp-tuning/tpe.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# TODO (andreyvelich) This metrics collector image (kubeflowkatib/custom-metrics-collector) doesn't work in v1beta1.
# It is currently using api.v1.alpha3.Manager instead of api.v1.beta1.Manager to report metrics.
apiVersion: kubeflow.org/v1beta1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/nas/darts-cpu.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/nas/darts-gpu.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/nas/enas-cpu.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This CPU example aims to show all the possible operations
# is not very likely to get good result due to the extensive search space

Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/nas/enas-gpu.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This GPU example aims to show all the possible operations
# is not very likely to get good result due to the extensive search space

Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/resume-experiment/from-volume-resume.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/resume-experiment/never-resume.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
1 change: 1 addition & 0 deletions examples/v1beta1/tekton/pipeline-run.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This example shows how you can use Tekton Pipelines in Katib, transfer parameters from one Task to another and run HP job.
# It uses simple random algorithm and tunes only learning rate.
# Pipelines contains 2 Tasks, first is data-preprocessing second is model-training.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kubeflow.org/v1beta1
kind: Experiment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
# This example shows how you can use trial metadata in template substitution
apiVersion: kubeflow.org/v1beta1
kind: Experiment
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: batch/v1
kind: Job
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/cert-generator/rbac.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/controller/controller.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/controller/katib-config.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: ConfigMap
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/controller/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/controller/rbac.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/controller/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Service
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: ConfigMap
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/crd/experiment.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/crd/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/crd/suggestion.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/crd/trial.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/db-manager/db-manager.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/db-manager/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/db-manager/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Service
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/mysql/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/mysql/mysql.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/mysql/pvc.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
Expand Down
3 changes: 2 additions & 1 deletion manifests/v1beta1/components/mysql/secret.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
apiVersion: v1
kind: Secret
type: Opaque
metadata:
name: katib-mysql-secrets
data:
MYSQL_ROOT_PASSWORD: dGVzdA== # "test"
MYSQL_ROOT_PASSWORD: dGVzdA== # "test"
1 change: 1 addition & 0 deletions manifests/v1beta1/components/mysql/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Service
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/namespace/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/namespace/namespace.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Namespace
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/ui/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/ui/rbac.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/ui/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Service
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/ui/ui.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/webhook/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/components/webhook/webhooks.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/installs/katib-cert-manager/params.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
varReference:
- path: spec/commonName
kind: Certificate
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
- op: add
path: /spec/template/spec/containers/0/args/-
value: "--enable-leader-election"
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
- op: "add"
path: "/metadata/annotations/service.beta.openshift.io~1serving-cert-secret-name"
value: katib-webhook-cert
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
- op: "add"
path: "/metadata/annotations"
value:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
Expand Down
1 change: 1 addition & 0 deletions manifests/v1beta1/installs/katib-with-kubeflow/params.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
varReference:
- path: spec/http/route/destination/host
kind: VirtualService
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
$patch: delete
apiVersion: v1
kind: Namespace
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
Expand Down

0 comments on commit 7bf3922

Please sign in to comment.