Rename paramater to more meaningful name

kubeflow · Jul 18, 2023 · 7d33b7b · 7d33b7b
1 parent 741059f
commit 7d33b7b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/metricscollector/v1beta1/kfp-metricscollector/v1/metrics_loader.py b/pkg/metricscollector/v1beta1/kfp-metricscollector/v1/metrics_loader.py
@@ -37,7 +37,7 @@ def find_all_files(directory):
             for f in files:
                 yield os.path.join(root, f)
 
-    def parse_metrics(self, fn: str) -> List[api_pb2.MetricLog]:
+    def parse_metrics(self, metric_file_path: str) -> List[api_pb2.MetricLog]:
         """Parse a kubeflow pipeline metrics file
 
         Args:
@@ -47,7 +47,7 @@ def parse_metrics(self, fn: str) -> List[api_pb2.MetricLog]:
             List[api_pb2.MetricLog]: A list of logged metrics
         """
         metrics = []
-        with open(fn) as f:
+        with open(metric_file_path) as f:
             metrics_dict = json.load(f)
             for m in metrics_dict["metrics"]:
                 name = m["name"]