Mini fix for v1alpha1 metricsCollector (#600)

kubeflow · May 28, 2019 · 99a4359 · 99a4359
1 parent 4f678e2
commit 99a4359
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/manager/v1alpha1/metricscollector/metricscollector.go b/pkg/manager/v1alpha1/metricscollector/metricscollector.go
@@ -47,7 +47,10 @@ func (d *MetricsCollector) CollectWorkerLog(wID string, wkind string, objectiveV
 	} else {
 		labelMap["job-name"] = wID
 	}
-	pl, _ := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labels.Set(labelMap).String(), IncludeUninitialized: true})
+	pl, err := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labels.Set(labelMap).String(), IncludeUninitialized: true})
+	if err != nil {
+		return nil, err
+	}
 	if len(pl.Items) == 0 {
 		return nil, errors.New(fmt.Sprintf("No Pods are found in Job %v", wID))
 	}