additional metric names should not include objective metric name (#1874)

kubeflow · May 25, 2022 · cc29580 · cc29580
1 parent 502695a
commit cc29580
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/pkg/webhook/v1beta1/experiment/validator/validator.go b/pkg/webhook/v1beta1/experiment/validator/validator.go
@@ -157,6 +157,9 @@ func (g *DefaultValidator) validateObjective(obj *commonapiv1beta1.ObjectiveSpec
 	if obj.ObjectiveMetricName == "" {
 		return fmt.Errorf("no spec.objective.objectiveMetricName specified")
 	}
+	if contains(obj.AdditionalMetricNames, obj.ObjectiveMetricName) {
+		return fmt.Errorf("spec.objective.additionalMetricNames should not contain spec.objective.objectiveMetricName")
+	}
 	return nil
 }
 

diff --git a/pkg/webhook/v1beta1/experiment/validator/validator_test.go b/pkg/webhook/v1beta1/experiment/validator/validator_test.go
@@ -108,6 +108,16 @@ func TestValidateExperiment(t *testing.T) {
 			Err:             true,
 			testDescription: "Objective metric name is empty",
 		},
+		{
+			Instance: func() *experimentsv1beta1.Experiment {
+				i := newFakeInstance()
+				i.Spec.Objective.ObjectiveMetricName = "objective"
+				i.Spec.Objective.AdditionalMetricNames = []string{"objective", "objective-1"}
+				return i
+			}(),
+			Err:             true,
+			testDescription: "additionalMetricNames should not contain objective metric name",
+		},
 		// Algorithm
 		{
 			Instance: func() *experimentsv1beta1.Experiment {