Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Supported Job List #1320

Closed
andreyvelich opened this issue Sep 2, 2020 · 7 comments · Fixed by #1573
Closed

Refactoring Supported Job List #1320

andreyvelich opened this issue Sep 2, 2020 · 7 comments · Fixed by #1573

Comments

@andreyvelich
Copy link
Member

/kind feature

After implementing custom CRD (#1214), SupportedJobList parameter can be omitted since Katib supports any Kind of CRD.

In some cases users want to manually modify controller source code to Mutate Trial Job before submission, see discussion: #1302 (comment) and #1273 (comment).

Let's discuss here what is the best way to implement this in the controller.

/cc @sperlingxx @gaocegege @johnugeorge

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.95

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.75

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.75

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@stale
Copy link

stale bot commented Dec 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Dec 1, 2020
@stale
Copy link

stale bot commented Dec 24, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Dec 24, 2020
@andreyvelich
Copy link
Member Author

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants