Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the tool of code generator for the gRPC API #2141

Open
Tracked by #2255
tenzen-y opened this issue Apr 3, 2023 · 10 comments · May be fixed by #2295
Open
Tracked by #2255

Replace the tool of code generator for the gRPC API #2141

tenzen-y opened this issue Apr 3, 2023 · 10 comments · May be fixed by #2295
Assignees

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Apr 3, 2023

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Currently, we are generating codes for the gRPC API from the protocol buffers definition with znly/protoc.

However, the image doesn't seem to be maintained since the latest image was published 4 years ago.

So, we should replace the toll with another one.

follow-up: #2140

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@tenzen-y
Copy link
Member Author

tenzen-y commented Apr 3, 2023

cc: @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member Author

tenzen-y commented Apr 3, 2023

Maybe, we can migrate the tool to the Buf.

@johnugeorge
Copy link
Member

Agree. We should try it out

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/lifecycle frozen

@andreyvelich
Copy link
Member

/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 29, 2024
@shivas1516
Copy link

shivas1516 commented Mar 6, 2024

From the description provided in this issue, I understand that the existing code generation tool 'znly/protoc' is not maintained properly, and there's a need to migrate to another tool, which has been mentioned in this conversation as Buf. As this issue is marked as a good first issue and aligns with my skill level, I'm keen to contribute to resolving it.

I'm seeking any guidance or recommendations to get started on this task. Your assistance and response are invaluable to me. Looking forward to your input!

@shivas1516
Copy link

/assign

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 7, 2024

From the description provided in this issue, I understand that the existing code generation tool 'znly/protoc' is not maintained properly, and there's a need to migrate to another tool, which has been mentioned in this conversation as Buf. As this issue is marked as a good first issue and aligns with my skill level, I'm keen to contribute to resolving it.

I'm seeking any guidance or recommendations to get started on this task. Your assistance and response are invaluable to me. Looking forward to your input!

@shivas1516 Your understanding is correct.
Feel free to open a PR. We’d be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment