Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multivariate TPE to Katib UI #1625

Merged
merged 2 commits into from Aug 17, 2021

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Aug 16, 2021

I updated Katib UI with Multivariate TPE Algorithm.
Also, I modified some Experiment parameters in create page.

/assign @c-bata @g-votte @kimwnasptd

@google-oss-robot
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: g-votte.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I updated Katib UI with Multivariate TPE Algorithm.

/assign @c-bata @g-votte @kimwnasptd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please show the preview of it?

@@ -78,6 +78,8 @@ export const TPESettings: AlgorithmSetting[] = [
},
];

export const MultivariateTPESettings: AlgorithmSetting[] = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multivariate TPE accepts the following algorithm settings:

  • startup_trials : integer
  • ei_candidates : integer
  • random_state : integer

if k == "startup_trials":
kwargs["n_startup_trials"] = int(v)
elif k == "ei_candidates":
kwargs["n_ei_candidates"] = int(v)
elif k == "random_state":
kwargs["seed"] = int(v)

@johnugeorge
Copy link
Member

johnugeorge commented Aug 17, 2021

This is one extra algorithm add in the UI
/lgtm

@johnugeorge
Copy link
Member

johnugeorge commented Aug 17, 2021

Got merged accidentally since it was already approved. Can we address the comments in separate PR?

@c-bata
Copy link
Member

c-bata commented Aug 17, 2021

Agree 👍 I think it doesn't need to revert the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants