Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes version to AWS CI #1758

Merged

Conversation

andreyvelich
Copy link
Member

I added Kubernetes version to our AWS CI.
We should be able to use this env: https://github.com/kubeflow/testing/blob/master/images/aws-scripts/create-eks-cluster.sh#L29

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

tenzen-y commented Dec 7, 2021

Thank you for upgrading the EKS version! @andreyvelich
As far as I read this document, it looks like Kubernetes v1.22 is not yet available for EKS.

@andreyvelich
Copy link
Member Author

I guess, we should re-built our AWS CI Worker Image if we want to use the latest eksctl version which supports K8s >= 1.19

@tenzen-y
Copy link
Member

tenzen-y commented Dec 7, 2021

I guess, we should re-built our AWS CI Worker Image if we want to use the latest eksctl version which supports K8s >= 1.19

It makes sense. @andreyvelich
The latest eksctl v0.76.0 seems to support Kubernetes v1.18, v1.19, v1.20, and v1.21.

EKS supports versions 1.18, 1.19, 1.20 and 1.21 (default). With eksctl you can deploy any of the supported versions by passing --version.

https://eksctl.io/introduction/#basic-cluster-creation

@coveralls
Copy link

coveralls commented Dec 7, 2021

Coverage Status

Coverage decreased (-0.1%) to 74.088% when pulling 8977e43 on andreyvelich:aws-ci-update-k8s-version into 1519724 on kubeflow:master.

@tenzen-y
Copy link
Member

FYI
The eksctl version will be changed to v0.76.0.
kubeflow/testing#972

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich andreyvelich changed the title [WIP] Add Kubernetes version to AWS CI Add Kubernetes version to AWS CI Feb 9, 2022
@andreyvelich
Copy link
Member Author

@tenzen-y @gaocegege @johnugeorge Let's merge this PR to use Kubernetes 1.19 version at least.
The 1.18 version is deprecated and will be disabled soon on EKS clusters.

@tenzen-y
Copy link
Member

tenzen-y commented Feb 9, 2022

Thanks for this update @andreyvelich!

This is just a comment.
I think we need to upgrade our CI Clusters version when K8s v1.22.x is released on EKS.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants