Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper constraint for Optuna #1852

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

himkt
Copy link
Contributor

@himkt himkt commented Apr 21, 2022

What this PR does / why we need it:

This PR introduces an upper version constraint for Optuna.
Please refer to #1851 for the background.

Which issue(s) this PR fixes:
Related #1851

Checklist:

  • Docs included if any changes are user facing => no user-faceing change

@aws-kf-ci-bot
Copy link
Contributor

Hi @himkt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR @himkt !

@kubeflow/wg-automl-leads Could you approve workflows in Github Action?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.93% when pulling 352a6db on himkt:optuna-version-constraint into 7f1afbd on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: himkt, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e9e8eab into kubeflow:master Apr 22, 2022
@himkt himkt deleted the optuna-version-constraint branch April 23, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants