[SDK] Enable resource specification for trial containers #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
johnugeorge
andreyvelich
reviewed
Aug 2, 2023
andreyvelich
reviewed
Aug 4, 2023
andreyvelich
reviewed
Aug 4, 2023
andreyvelich
reviewed
Aug 4, 2023
droctothorpe
force-pushed
the
resources
branch
3 times, most recently
from
0440fc3
to
052fd34
Compare
tenzen-y
reviewed
Aug 4, 2023
Co-authored-by: shipengcheng1230 <shipengcheng1230@gmail.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Thank you for this great feature @droctothorpe!
/lgtm
/assign @tenzen-y @johnugeorge @gaocegege
tenzen-y
reviewed
Aug 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the only way to specify cpu and memory limits and requests for trial containers is by submitting a manifest directly. For example: here.
This PR adds resource specification capabilities to the SDK's
tunemethod to achieve parity with direct manifest submission.resources_per_trialdefaults toNone, which aligns with whatkubernetes.client.V1ResourceRequirementsdefaults to, so whenresources_per_trialis not specified, the behavior is unmodified.Which issue(s) this PR fixes
Fixes #2191