Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to inject the metrics-collector pods to the katib controller #2203

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I introduced the label to skip injecting the metrics-collector to the katib system components.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2069

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y tenzen-y marked this pull request as ready for review August 15, 2023 12:18
@tenzen-y tenzen-y changed the title Skip to inject the metrics-collector pods to the katib system components Skip to inject the metrics-collector pods to the katib controller Aug 15, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

tenzen-y commented Aug 15, 2023

I discussed offline with @andreyvelich and @johnugeorge.

Let me summarize. The replicaset controller occasionally faces the following errors since the webhooks are registered to the kube-apiserver before the controller pod is started.

Warning  FailedCreate  39s (x15 over 2m2s)  replicaset-controller  Error creating: Internal error occurred: failed calling webhook "mutator.pod.katib.kubeflow.org": failed to call webhook: Post "[https://katib-controller.kubeflow.svc:443/mutate-pod?timeout=10s](https://katib-controller.kubeflow.svc/mutate-pod?timeout=10s)": dial tcp 10.100.157.27:443: connect: connection refused

So we set the label to avoid injecting the metrics-collector pod only into the controller pod.

Also in the future, we will switch to AdmissionWebhookMatchConditions feature to process requests more accurately once the feature gate is enabled as a default.

@tenzen-y
Copy link
Member Author

/assign @andreyvelich @johnugeorge

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tenzen-y!
/lgtm
/hold for review
/assign @johnugeorge @gaocegege

@johnugeorge
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 4dbb49f into kubeflow:master Aug 15, 2023
59 checks passed
@tenzen-y tenzen-y deleted the add-ignore-mutate-label branch August 15, 2023 18:13
tenzen-y added a commit to tenzen-y/katib that referenced this pull request Aug 16, 2023
google-oss-prow bot pushed a commit that referenced this pull request Aug 16, 2023
…pods to the katib controller (#2211)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Label to Disable Katib Webhooks
4 participants