Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a katib-webhook-cert Secret from components #2207

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 15, 2023

What this PR does / why we need it:
I removed a katib-webhook-cert Secret from the components directory to avoid startup issues in the cert-manager installation.

Need katib-webhook-cert

  • katib-external-db
  • katib-leader-election
  • katib-standalone
  • katib-standalone-postgres

NOT to need katib-webhook-cert

  • katib-cert-manager
  • katib-openshift
  • katib-with-kubeflow

Also, I confirmed built manifests like this:

$ kustomize build manifests/v1beta1/installs/katib-cert-manager/ | grep -C2 "name: katib-webhook-cert"
kind: Certificate
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
spec:
$ kustomize build manifests/v1beta1/installs/katib-external-db/ | grep -C2 "name: katib-webhook-cert"
kind: Secret
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
---
$ kustomize build manifests/v1beta1/installs/katib-leader-election/ | grep -C2 "name: katib-webhook-cert"
kind: Secret
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
---
$ kustomize build manifests/v1beta1/installs/katib-openshift/ | grep -C2 "name: katib-webhook-cert"
    prometheus.io/scheme: http
    prometheus.io/scrape: "true"
    service.beta.openshift.io/serving-cert-secret-name: katib-webhook-cert
  labels:
    katib.kubeflow.org/component: controller
$ kustomize build manifests/v1beta1/installs/katib-standalone/ | grep -C2 "name: katib-webhook-cert"
kind: Secret
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
---
$ kustomize build manifests/v1beta1/installs/katib-standalone-postgres/ | grep -C2 "name: katib-webhook-cert"
kind: Secret
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
---
$ kustomize build manifests/v1beta1/installs/katib-with-kubeflow/ | grep -C2 "name: katib-webhook-cert"
kind: Certificate
metadata:
  name: katib-webhook-cert
  namespace: kubeflow
spec:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -15,6 +15,8 @@ resources:
- ../../components/ui/
# Katib webhooks.
- ../../components/webhook/
# Secret for webhooks certs.
- ./katib-webhook-cert.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we can simplify this as follows in the Kustomization file:

secretGenerator:
  - name: katib-webhook-cert
    options:
      disableNameSuffixHash: true

WDYT @tenzen-y ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point! Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tenzen-y tenzen-y force-pushed the remove-webhook-cert-from-kf-installation branch from 3dc9a29 to ab2154c Compare August 15, 2023 16:26
@tenzen-y tenzen-y changed the title WIP: Remove a katib-webhook-cert Secret from components Remove a katib-webhook-cert Secret from components Aug 15, 2023
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @tenzen-y!
/lgtm

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the remove-webhook-cert-from-kf-installation branch from ab2154c to f0aec11 Compare August 15, 2023 18:18
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 15, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@andreyvelich
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot merged commit aa772b6 into kubeflow:master Aug 15, 2023
59 checks passed
tenzen-y added a commit to tenzen-y/katib that referenced this pull request Aug 16, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y deleted the remove-webhook-cert-from-kf-installation branch August 16, 2023 08:15
google-oss-prow bot pushed a commit that referenced this pull request Aug 16, 2023
…om components (#2214)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants