New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a katib-webhook-cert Secret from components #2207
Remove a katib-webhook-cert Secret from components #2207
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -15,6 +15,8 @@ resources: | |||
- ../../components/ui/ | |||
# Katib webhooks. | |||
- ../../components/webhook/ | |||
# Secret for webhooks certs. | |||
- ./katib-webhook-cert.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we can simplify this as follows in the Kustomization file:
secretGenerator:
- name: katib-webhook-cert
options:
disableNameSuffixHash: true
WDYT @tenzen-y ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
3dc9a29
to
ab2154c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update @tenzen-y!
/lgtm
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
ab2154c
to
f0aec11
Compare
New changes are detected. LGTM label has been removed. |
/lgtm |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
…om components (#2214) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
What this PR does / why we need it:
I removed a katib-webhook-cert Secret from the components directory to avoid startup issues in the cert-manager installation.
Need katib-webhook-cert
NOT to need katib-webhook-cert
Also, I confirmed built manifests like this:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: