updated dockerfiles for grpc builds for powerPC compilation~ #2262

pranavpandit1 · 2024-02-20T14:16:19Z

This PR targets to get the katib/suggestions built on PowerPC.

google-oss-prow · 2024-02-20T14:16:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pranavpandit1
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: pranav pandit <pranav.pandit1@ibm.com>

tenzen-y · 2024-03-02T17:09:49Z

Uhm, I'm wondering if we shouldn't support ppc64le env since the validation environment generally doesn't exist.
@andreyvelich @johnugeorge WDYT?

lehrig · 2024-03-07T09:42:01Z

@tenzen-y - note that this PR is part of a greater effort to enable Kubeflow and all its dependencies for multiple processor architectures (we start with ppc64le): kubeflow/kubeflow#6684

We do have an enterprise-supported ppc64le Kubeflow distribution (https://www.ibm.com/docs/en/announcements/rocket-ai-hub-power) and are ensuring validation / take care of upstream fixing if needed. I hope that helps...

tenzen-y · 2024-03-09T12:37:59Z

@tenzen-y - note that this PR is part of a greater effort to enable Kubeflow and all its dependencies for multiple processor architectures (we start with ppc64le): kubeflow/kubeflow#6684

We do have an enterprise-supported ppc64le Kubeflow distribution (https://www.ibm.com/docs/en/announcements/rocket-ai-hub-power) and are ensuring validation / take care of upstream fixing if needed. I hope that helps...

I see. I didn't know it.
@kubeflow/wg-automl-leads Did you approve this ppc64le projects? If so, I'm ok with proceeding with this PR.

tenzen-y

Could you update CI as well?
For example, we should update this platform

katib/.github/workflows/publish-algorithm-images.yaml

Line 15 in a2f3fca

platforms: linux/amd64,linux/arm64

katib/.github/workflows/publish-core-images.yaml

Line 13 in a2f3fca

platforms: linux/amd64,linux/arm64

tenzen-y · 2024-03-09T12:41:07Z

cmd/suggestion/hyperband/v1beta1/Dockerfile

@@ -5,9 +5,12 @@ ENV TARGET_DIR /opt/katib
 ENV SUGGESTION_DIR cmd/suggestion/hyperband/v1beta1
 ENV PYTHONPATH ${TARGET_DIR}:${TARGET_DIR}/pkg/apis/manager/v1beta1/python:${TARGET_DIR}/pkg/apis/manager/health/python

-RUN if [ "${TARGETARCH}" = "ppc64le" ] || [ "${TARGETARCH}" = "arm64" ]; then \


Any reasons to remove arm64 from here?

No specific reason but I think its typo and we can fix it by nested if-else condition.

Sorry, I couldn't follow it. where is a typo?
Could you clarify it? Thanks.

I think, these packages are required to support arm64, isn't ?

We verify grpcio installation only for ppc64le but not for arm64 and while raising the PR, I think arm64 has been mistakenly removed in hyperband dockerfile. So will update dockerfile and add a condition where if it is ppc64le then only install grpcio from source...

We verify grpcio installation only for ppc64le but not for arm64 and while raising the PR, I think arm64 has been mistakenly removed in hyperband dockerfile. So will update dockerfile and add a condition where if it is ppc64le then only install grpcio from source...

Ah, I see. Thanks.

tenzen-y · 2024-03-09T12:42:32Z

cmd/suggestion/hyperband/v1beta1/Dockerfile

+    export REPO_ROOT=grpc && git clone -b v1.60.1 https://github.com/grpc/grpc $REPO_ROOT && \
+    cd $REPO_ROOT && git submodule update --init && \
+    pip install -r requirements.txt && GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 pip install . && \


Any other approach using a package manager like apt?

I'm checking alternate approach for grpcio installation..once done will add it here.Thanks

@tenzen-y Yes we can install grpcio by setting flag GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 to pip install and have verified all the dockerfiles with the same changes. I will update the PR.

aditijadhav38 · 2024-03-13T14:11:30Z

Could you update CI as well? For example, we should update this platform

katib/.github/workflows/publish-algorithm-images.yaml

Line 15 in a2f3fca

platforms: linux/amd64,linux/arm64

katib/.github/workflows/publish-core-images.yaml

Line 13 in a2f3fca

platforms: linux/amd64,linux/arm64

@tenzen-y Actually we are adding ppc64le support for other Katib components as well which is in progress. So once we are in good position where all katib components's dockerfile have ppc64le support then we can proceed with updating CI.. WDYT?

tenzen-y · 2024-03-13T14:25:15Z

Could you update CI as well? For example, we should update this platform

katib/.github/workflows/publish-algorithm-images.yaml

Line 15 in a2f3fca

platforms: linux/amd64,linux/arm64

katib/.github/workflows/publish-core-images.yaml

Line 13 in a2f3fca

platforms: linux/amd64,linux/arm64

@tenzen-y Actually we are adding ppc64le support for other Katib components as well which is in progress. So once we are in good position where all katib components's dockerfile have ppc64le support then we can proceed with updating CI.. WDYT?

We shouldn't add any images without verifying in CI. It will cause us to lose maintainability and stability.
I didn't mean that "I can not believe you", and my primary concern is the future maintainability.

andreyvelich

Thank you for starting to add support powerPC builds in Katib! A few questions.

What are your thoughts on this: Add support for ppc64le argoproj/argo-workflows#12449. How we can ensure that we have enough maintenance support and user stories around using Kubeflow with PowerPC?
As @tenzen-y said here: updated dockerfiles for grpc builds for powerPC compilation~ #2262 (comment), we need to add those builds to the CI/CD. Otherwise, users will get confused if we support PowerPC out-of-the-box.

andreyvelich · 2024-03-13T17:49:52Z

cmd/suggestion/hyperband/v1beta1/Dockerfile

@@ -5,9 +5,12 @@ ENV TARGET_DIR /opt/katib
 ENV SUGGESTION_DIR cmd/suggestion/hyperband/v1beta1
 ENV PYTHONPATH ${TARGET_DIR}:${TARGET_DIR}/pkg/apis/manager/v1beta1/python:${TARGET_DIR}/pkg/apis/manager/health/python

-RUN if [ "${TARGETARCH}" = "ppc64le" ] || [ "${TARGETARCH}" = "arm64" ]; then \


I think, these packages are required to support arm64, isn't ?

andreyvelich · 2024-03-13T17:58:36Z

cc @kubeflow/wg-training-leads

lehrig · 2024-03-14T19:14:58Z

What are your thoughts on this: Add support for ppc64le argoproj/argo-workflows#12449. How we can ensure that we have enough maintenance support and user stories around using Kubeflow with PowerPC?

@andreyvelich, I have directly added a comment there: argoproj/argo-workflows#12449 (comment)

What I describe there also holds true here - we are happy to help maintaining, especially if anything architecture-specific comes up. Hope that helps.

mkumatag · 2024-03-18T00:34:58Z

cmd/suggestion/hyperband/v1beta1/Dockerfile

+    apt-get -y install gfortran libopenblas-dev liblapack-dev libssl-dev gcc g++ pkg-config git && \
+    export REPO_ROOT=grpc && git clone -b v1.60.1 https://github.com/grpc/grpc $REPO_ROOT && \
+    cd $REPO_ROOT && git submodule update --init && \
+    pip install -r requirements.txt && GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 pip install . && \


You don't need a git clone here, you can just set this flag GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 down in the pip install block to ensure pip source building doesn't pick up the BoringSSL library.

@mkumatag Thanks for your response and yes I was able to verify the grpc installation by setting the flag GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1. I will update PR with the changes.

aditijadhav38 · 2024-03-19T07:36:48Z

@tenzen-y I have raised new PR #2290 with the suggested changes and I've also updated one more dockerfile earlystopping/medianstop which needs similar changes for grpc installation.
Also as per your suggestion I have updated CI files as well. But please note that we haven't added support for all Katib components, hence for few images (for which dockerfiles are not yet updated for eg. nas/enas, katib-ui, katib/tfevent-metricscollector) the build might fail. We are currently working on remaining components mentioned above.

google-oss-prow bot added the size/M label Feb 20, 2024

google-oss-prow bot requested review from andreyvelich, anencore94 and johnugeorge February 20, 2024 14:16

updated dockerfiles for grpc builds for powerPC compilation~

61faad0

Signed-off-by: pranav pandit <pranav.pandit1@ibm.com>

pranavpandit1 force-pushed the master branch from 59f0cb6 to 61faad0 Compare February 20, 2024 14:17

lehrig mentioned this pull request Mar 7, 2024

Umbrella Issue: Porting Kubeflow to IBM Power (ppc64le) kubeflow/kubeflow#6684

Open

54 tasks

tenzen-y reviewed Mar 9, 2024

View reviewed changes

andreyvelich reviewed Mar 13, 2024

View reviewed changes

mkumatag suggested changes Mar 18, 2024

View reviewed changes

aditijadhav38 mentioned this pull request Mar 19, 2024

Updated dockerfiles for grpc installation for ppc64le #2290

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated dockerfiles for grpc builds for powerPC compilation~ #2262

updated dockerfiles for grpc builds for powerPC compilation~ #2262

pranavpandit1 commented Feb 20, 2024

google-oss-prow bot commented Feb 20, 2024

tenzen-y commented Mar 2, 2024

lehrig commented Mar 7, 2024

tenzen-y commented Mar 9, 2024

tenzen-y left a comment

tenzen-y Mar 9, 2024

aditijadhav38 Mar 13, 2024 •

edited

tenzen-y Mar 13, 2024

andreyvelich Mar 13, 2024

aditijadhav38 Mar 14, 2024

tenzen-y Mar 14, 2024

tenzen-y Mar 9, 2024

aditijadhav38 Mar 13, 2024 •

edited

aditijadhav38 Mar 18, 2024

aditijadhav38 commented Mar 13, 2024

tenzen-y commented Mar 13, 2024 •

edited

andreyvelich left a comment •

edited

andreyvelich Mar 13, 2024

andreyvelich commented Mar 13, 2024

lehrig commented Mar 14, 2024 •

edited

mkumatag Mar 18, 2024

aditijadhav38 Mar 18, 2024 •

edited

aditijadhav38 commented Mar 19, 2024

updated dockerfiles for grpc builds for powerPC compilation~ #2262

Are you sure you want to change the base?

updated dockerfiles for grpc builds for powerPC compilation~ #2262

Conversation

pranavpandit1 commented Feb 20, 2024

google-oss-prow bot commented Feb 20, 2024

tenzen-y commented Mar 2, 2024

lehrig commented Mar 7, 2024

tenzen-y commented Mar 9, 2024

tenzen-y left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aditijadhav38 Mar 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aditijadhav38 Mar 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aditijadhav38 commented Mar 13, 2024

tenzen-y commented Mar 13, 2024 • edited

andreyvelich left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreyvelich commented Mar 13, 2024

lehrig commented Mar 14, 2024 • edited

Choose a reason for hiding this comment

aditijadhav38 Mar 18, 2024 • edited

Choose a reason for hiding this comment

aditijadhav38 commented Mar 19, 2024

aditijadhav38 Mar 13, 2024 •

edited

aditijadhav38 Mar 13, 2024 •

edited

tenzen-y commented Mar 13, 2024 •

edited

andreyvelich left a comment •

edited

lehrig commented Mar 14, 2024 •

edited

aditijadhav38 Mar 18, 2024 •

edited