Support ARM64 arch for release images #2315
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
anencore94,
gaocegege and
johnugeorge
| 1. Make sure that you can build all Katib images. **Note** that | ||
| your Docker Desktop should | ||
| [enable containerd image store](https://docs.docker.com/desktop/containerd/#enable-the-containerd-image-store) | ||
| to build multi-arch images: |
There was a problem hiding this comment.
Could you update the developer docs as well?
https://github.com/kubeflow/katib/blob/master/docs/developer-guide.md#requirements
Also, could you update the minimum required Docker version with v24.0.0 since the containerd image store is introduced in that version: https://github.com/moby/moby/releases/tag/v24.0.0
There was a problem hiding this comment.
@tenzen-y Makes sense, I updated the Developer guide.
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
|
/assign @johnugeorge @tenzen-y |
This PR should add support for
arm64images to our release script./assign @tenzen-y @johnugeorge