Use latest katib images to deploy katib #682
Conversation
| @@ -23,7 +23,7 @@ data: | |||
| serviceAccountName: metrics-collector | |||
| containers: | |||
| - name: {{.WorkerID}} | |||
| image: katib/metrics-collector | |||
| image: gcr.io/kubeflow-images-public/katib/v1alpha1/metrics-collector | |||
There was a problem hiding this comment.
@johnugeorge Do we have the repository in dockerhub? If not I think the PR LGTM
There was a problem hiding this comment.
AFAIK, we hasn't maintained katib images in dockerhub for a long time. some users try to install katib by deploy.sh, but Katib cannot work well for the images are too old
There was a problem hiding this comment.
I think, it is better to keep single source of truth. Since our images are built in gcr, this PR looks good to me than maintaining in two different repos.
One related question is, should we point to release tagged image than picking up the latest image from master? Release image can be updated in the manifests after every release. eg: 0.6 Else, users might see new untested features and different behavior from the docs which will be confusing to them.
There was a problem hiding this comment.
@johnugeorge, Agree with you. But I think for master branch, we can just keep latest images which keep consistent with master source code. For a released branch, we should modify the images with released version tag.
There was a problem hiding this comment.
@hougangliu But, won't users deploy Katib from master branch always?
There was a problem hiding this comment.
we can doc about what images the installer will use. In fact, for end user, I think he should install katib by kubeflow kfctl, which always installs released images. For deploy.sh here, it is prepared for developers, who're likely to test how current code runs.
There was a problem hiding this comment.
SGTM. If developers need to use our scripts to deploy(without Katib), we can provide link to the manifests of last deployed branch. We need to add this to README
|
/test kubeflow-katib-presubmit |
|
test env is broken in all repos now. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After this patch, user can install katib individually (not install kubeflow) with latest images by
deploy.sh.This change is