reduce build time #84
Conversation
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
|
/assign @gaocegege |
This comment has been minimized.
This comment has been minimized.
|
Sorry, I misunderstand the script. The building time is reduced from 45 mins to 25 mins. |
|
Though build time was reduced, is it still not enough? 🤔 |
|
But it is still too long... |
|
Maybe we should parallel build the images as jose5918@ suggested. |
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
It looks to build parallelly. But it may replace Dockerfile before sending the code to gcloud... |
|
/LGTM |
|
I think we could separate the building process into different containers. For example. one is for manager and another is for CLI. Then we could run parallel building in container level. But the code LGTM since it works. |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #50
Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com