-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Argo variables to Tekton varaibles. #78
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
/assign |
Currently this is the equivalent variable matching i found. Since we don't have other equivalent matching for the rest of the argo variables, we will prompt a warning when those argo variables are used. Since KFP also don't recommend to use Argo variables because it requires specific knowledge on Argo pipeline. The other places argo variables are used is during artifact output path. We can workaround with this by creating our own s3/gcs tasks to parse artifact output path using environment variables. This way we don't have to rely on Tekton to replace those workflow variables during execution. However, this means we need to maintain our own s3/gcs task for artifact storing. |
Is this what you meant with ...
in #18 (comment) ? |
yes |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
KFP uses Argo variables to refer artifact locations and exit ops status. Therefore, we want to map as much variables in Argo as possible since issues #64 and other pipelines assume those variable can be interpreted during execution.
As of today, Tekton variables $() only has inputs and outputs params on the task level. For other variables, we will try to map them with env variables using Kubernetes FieldRef Parameter.
However, many Argo variables are still not possible with Tekton variables and pure Kubernetes FieldRef Parameter. Thus, we will raise a warning for users to avoid using them in a pipeline.
The text was updated successfully, but these errors were encountered: