Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(backend): Tekton v1 migration #1309

Merged
merged 13 commits into from Aug 2, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Jul 31, 2023

**Which issue is resolved by this Pull Request:
part of #1308

Description of your changes:
follow up PR #1297

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Jul 31, 2023

Pipelineloop, SDK, and frontend migration will be in separate PRs.

1 similar comment
@Tomcli
Copy link
Member Author

Tomcli commented Jul 31, 2023

Pipelineloop, SDK, and frontend migration will be in separate PRs.

@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Aug 1, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Aug 1, 2023

@yhwang basic backend backward compatibility for v1beta1 pipelines are supported in this code. However, all the status are in v1 now and v1 no longer has fields for taskrun and run status. Also some spec and result location are different now.
https://cloud.ibm.com/devops/pipelines/tekton/f85a45d2-36fc-45fb-a449-b01c13cf5191/runs/25d595b6-8ce5-401e-a991-84e74a90cfb6/e2e-test-cache/run-test?env_id=ibm:yp:us-south

@Tomcli
Copy link
Member Author

Tomcli commented Aug 1, 2023

Next step I will do is adding sdk migration. After this PR is merged, the sdk, frontend, and pipelineloop will not be compatible until my follow up PRs are merged.
The product and kubeflow community will be using kfp-tekton 1.7.x branch, so master can be in development mode for now.

@Tomcli
Copy link
Member Author

Tomcli commented Aug 1, 2023

/assign @yhwang

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 2, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fde417c into kubeflow:master Aug 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants