-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial pipelinerun support #62
Conversation
/assign @ckadner |
Thanks @Tomcli, I will take a look. |
Hi @Tomcli, sorry for the delay. I am still thinking about this. I don't like dragging in ever more of the KFP compiler code, only to accommodate small bits of code changes. But due to the sub-optimal code structure small changes sometimes come with a long tail. Besides that we have an unfortunate mix of inheritance with overriding classes and class methods, but we rely on monkey-patching to dynamically replace static methods. So we need to ensure all possible entry points to the compiler, like main, CLI, unit tests, direct instantiations all trigger the monkey-patch but not when the actual KFP functions are desired (i.e. using And conceptually I prefer generating I will take a little break and get back to this with fresh eyes a little later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -46,6 +46,18 @@ def my_pipeline(a: int = 1, b: str = "default value"): | |||
``` | |||
""" | |||
|
|||
def compile(self, pipeline_func, package_path, type_check=True, pipeline_conf: dsl.PipelineConf = None, generate_pipelinerun=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move the compile
function down to just above _write_workflow
so that when we compare code changes with KFP all the methods line up
and break the line before the generate_pipelinerun
argument to keep the line length below 120 for code style compliance and better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ckadner, I moved the compile function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tomcli
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chore: Update ODH Manifests README
Add initial pipelinerun support for development purpose. This PR didn't add any breaking change to the existing compiler. Features such as pipeline timeout and workspaces will come in the following PR since those are breaking features that might require monkey patches on the pipeline dsl definition.
Example usage:
or in Python
I will also extend it to the developer guide once it's ready.