Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubebench Dashboard added #133

Merged
merged 17 commits into from Dec 7, 2018
Merged

Kubebench Dashboard added #133

merged 17 commits into from Dec 7, 2018

Conversation

Akado2009
Copy link
Contributor

@Akado2009 Akado2009 commented Nov 7, 2018

Fixes: #125


This change is Reviewable

@Akado2009
Copy link
Contributor Author

/retest

Copy link
Member

@xyhuang xyhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these files needed:

Dockerfile_controller
Dockerfile_dashboard
dashboard/kubebench-dashboard/build_image.sh
dashboard/kubebench-dashboard/frontend/README.md
dashboard/kubebench-dashboard/Makefile

@Akado2009
Copy link
Contributor Author

@xyhuang gonna get rid of them.

@xyhuang
Copy link
Member

xyhuang commented Dec 7, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xyhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6f87d31 into kubeflow:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants