Skip to content

Commit

Permalink
Setting the base_url flag of Jupyter images (#2627)
Browse files Browse the repository at this point in the history
* set base_url of jupyter

* change the env base_url to NB_PREFIX to sync with #2620
  • Loading branch information
zabbasi authored and k8s-ci-robot committed Mar 6, 2019
1 parent 20431c4 commit 74ac37c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion components/tensorflow-notebook-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ENV DEBIAN_FRONTEND noninteractive
ENV NB_USER jovyan
ENV NB_UID 1000
ENV HOME /home/$NB_USER
ENV NB_PREFIX /
# We prefer to have a global conda install
# to minimize the amount of content in $HOME
ENV CONDA_DIR=/opt/conda
Expand Down Expand Up @@ -155,5 +156,5 @@ RUN docker-credential-gcr configure-docker && chown jovyan:users $HOME/.docker/c
# Configure container startup
EXPOSE 8888
ENTRYPOINT ["tini", "--"]
CMD ["sh","-c", "jupyter notebook --notebook-dir=/home/jovyan --ip=0.0.0.0 --no-browser --allow-root --port=8888 --NotebookApp.token='' --NotebookApp.password='' --NotebookApp.allow_origin='*'"]
CMD ["sh","-c", "jupyter notebook --notebook-dir=/home/jovyan --ip=0.0.0.0 --no-browser --allow-root --port=8888 --NotebookApp.token='' --NotebookApp.password='' --NotebookApp.allow_origin='*' --NotebookApp.base_url=${NB_PREFIX}"]

0 comments on commit 74ac37c

Please sign in to comment.