Clarify jobName param, remove Fix this since it has been integrated i…

…nto all.libsonnet as intended.
kubeflow · Oct 10, 2018 · 982dcd4 · 982dcd4
1 parent 5be2c65
commit 982dcd4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/kubeflow/spark/all.libsonnet b/kubeflow/spark/all.libsonnet
@@ -310,7 +310,6 @@
           labels: {
             version: sparkVersion,
           },
-          // Fix this
           serviceAccount: params.name + "-spark",
           volumeMounts: [
             {

diff --git a/kubeflow/spark/prototypes/spark-job.jsonnet b/kubeflow/spark/prototypes/spark-job.jsonnet
@@ -3,7 +3,7 @@
 // @param name string Name for the component
 // @param applicationResource string jar or pyfile reference for spark-submit
 // @optionalParam namespace string default namespace to run in
-// @optionalParam jobName string defaultjob Name for the component
+// @optionalParam jobName string defaultjob Name for the job
 // @optionalParam mainClass string null JVM Class name of driver entry point
 // @optionalParam type string Scala Type of applicaiton (e.g. Scala, Python)
 // @optionalParam driverCores number 2 number of cores for driver