Skip to content

Commit

Permalink
* In most recent Jupyter images, JupyterLab wasn't working we can an
Browse files Browse the repository at this point in the history
  error about index.html not found

* Upgrade JupyterLab to 0.31 try to fix it.

* Built a new image
  gcr.io/kubeflow-images-staging/tensorflow-notebook-cpu:v20180301-1958-pr328-0bc73dc-a43d

 and verified that the image is working.
  • Loading branch information
jlewi committed Mar 2, 2018
1 parent 101a87a commit b89dcf2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion components/tensorflow-notebook-image/Dockerfile.cpu
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ RUN cd /tmp && \
RUN conda install --quiet --yes \
'notebook=5.0.*' \
'jupyterhub=0.8.1' \
'jupyterlab=0.24.*' \
'jupyterlab=0.31.*' \
&& conda clean -tipsy

EXPOSE 8888
Expand Down
2 changes: 1 addition & 1 deletion components/tensorflow-notebook-image/Dockerfile.gpu
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ RUN cd /tmp && \
RUN conda install --quiet --yes \
'notebook=5.0.*' \
'jupyterhub=0.8.1' \
'jupyterlab=0.24.*' \
'jupyterlab=0.31.*' \
&& conda clean -tipsy

USER root
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ params + {
workflows +: {
bucket: "kubeflow-releasing-artifacts",
gcpCredentialsSecretName: "gcp-credentials",
name: "jlewi-notebook-release-317-0892",
name: "jlewi-notebook-release-328-a43d",
namespace: "kubeflow-releasing",
prow_env: "JOB_NAME=notebook-release,JOB_TYPE=presubmit,PULL_NUMBER=317,REPO_NAME=kubeflow,REPO_OWNER=kubeflow,BUILD_NUMBER=0892",
prow_env: "JOB_NAME=notebook-release,JOB_TYPE=presubmit,REPO_NAME=kubeflow,REPO_OWNER=kubeflow,BUILD_NUMBER=a43d,PULL_NUMBER=328,PULL_PULL_SHA=0bc73dc",
registry: "gcr.io/kubeflow-images-staging",
versionTag: "v20180301-pr317",
versionTag: "v20180301-1958-pr328-0bc73dc-a43d",
},
},
}

0 comments on commit b89dcf2

Please sign in to comment.