Add docker-for-desktop platform

- Steps required are similar to minikube, nothing special Signed-off-by: Roberto Gandolfo Hashioka <roberto_hashioka@hotmail.com>
kubeflow · Nov 15, 2018 · c975d32 · c975d32
1 parent 2c0b45e
commit c975d32
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/scripts/kfctl.sh b/scripts/kfctl.sh
@@ -44,6 +44,10 @@ createEnv() {
       echo KUBEFLOW_PLATFORM=minikube >> ${ENV_FILE}
       echo MOUNT_LOCAL=${MOUNT_LOCAL} >> ${ENV_FILE}
       ;;
+    docker-for-desktop)
+      echo KUBEFLOW_PLATFORM=docker-for-desktop >> ${ENV_FILE}
+      echo MOUNT_LOCAL=${MOUNT_LOCAL} >> ${ENV_FILE}
+      ;;
     ack)
       echo KUBEFLOW_PLATFORM=ack >> ${ENV_FILE}
       echo KUBEFLOW_DOCKER_REGISTRY=registry.aliyuncs.com >> ${ENV_FILE}
@@ -238,7 +242,7 @@ customizeKsApp() {
 ksApply () {
   pushd ${KUBEFLOW_KS_DIR}
 
-  if [ "${PLATFORM}" == "minikube" ]; then
+  if [ "${PLATFORM}" == "minikube" ]  || [ "${PLATFORM}" == "docker-for-desktop" ]; then
     createNamespace
   fi
 
@@ -262,15 +266,15 @@ ksApply () {
   ks apply default -c spartakus
 
   # Reduce resource demands locally
-  if [ "${PLATFORM}" != "minikube" ]; then
+  if [ "${PLATFORM}" != "minikube" ]  && [ "${PLATFORM}" != "docker-for-desktop" ]; then
     ks apply default -c argo
     ks apply default -c katib
   fi
 
   popd
 
   set +x
-  if [ "${PLATFORM}" == "minikube" ]; then
+  if [ "${PLATFORM}" == "minikube" ]  || [ "${PLATFORM}" == "docker-for-desktop" ]; then
     if is_kubeflow_ready; then
       mount_local_fs
       setup_tunnels
@@ -300,7 +304,7 @@ if [ "${COMMAND}" == "generate" ]; then
       gcpGenerateKsApp
     fi
 
-    if [ "${PLATFORM}" == "minikube" ]; then
+    if [ "${PLATFORM}" == "minikube" ]  || [ "${PLATFORM}" == "docker-for-desktop" ]; then
       create_local_fs_mount_spec
       if ${MOUNT_LOCAL}; then
         ks param set jupyter disks "local-notebooks"