fix tests

kubeflow · Mar 22, 2018 · e26874b · e26874b
1 parent 23b81c5
commit e26874b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/kubeflow/core/jupyterhub.libsonnet b/kubeflow/core/jupyterhub.libsonnet
@@ -186,7 +186,6 @@ c.RemoteUserAuthenticator.header_name = 'x-goog-authenticated-user-email'",
                   {
                     name: "NOTEBOOK_PVC_MOUNT",
                     value: notebookPVCMount
-
                   },
                 ]
               },  // jupyterHub container

diff --git a/kubeflow/core/jupyterhub_spawner.py b/kubeflow/core/jupyterhub_spawner.py
@@ -93,7 +93,7 @@ def extra_resource_limits(self):
 # TODO(jlewi): Verify this works on minikube.
 # TODO(jlewi): Should we set c.KubeSpawner.singleuser_fs_gid = 1000
 # see https://github.com/kubeflow/kubeflow/pull/22#issuecomment-350500944
-pvc_mount = os.environ.get("NOTEBOOK_PVC_MOUNT")
+pvc_mount = os.environ.get('NOTEBOOK_PVC_MOUNT')
 if pvc_mount:
     c.KubeSpawner.user_storage_pvc_ensure = True
     # How much disk space do we want?

diff --git a/kubeflow/core/tests/jupyterhub_test.jsonnet b/kubeflow/core/tests/jupyterhub_test.jsonnet
@@ -105,6 +105,10 @@ std.assertEqual(jupyterhub.parts(params.namespace).jupyterHub(params.jupyterHubI
                         "containerPort": 8081
                      }
                   ],
+		  "env": [
+			"name": "NOTEBOOK_PVC_MOUNT",
+			"value": "/home/jovyan/work"
+                  ]
                   "volumeMounts": [
                      {
                         "mountPath": "/etc/config",