turn off Istio isolation for basic auth (#3675)

* turn off Istio isolation for basic auth * set param in config instead
kubeflow · Jul 17, 2019 · e6944f3 · e6944f3
1 parent d0c11dd
commit e6944f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/bootstrap/config/overlays/istio/kfctl_default.yaml b/bootstrap/config/overlays/istio/kfctl_default.yaml
@@ -20,6 +20,9 @@ spec:
     istio-install:
     - name: namespace
       value: istio-system
+    istio:
+    - name: clusterRbacConfig
+      value: "ON"
     iap-ingress:
     - name: namespace
       value: istio-system

diff --git a/bootstrap/pkg/kfapp/gcp/gcp.go b/bootstrap/pkg/kfapp/gcp/gcp.go
@@ -1707,6 +1707,9 @@ func (gcp *Gcp) Generate(resources kftypes.ResourceEnum) error {
 		if err := gcp.kfDef.SetApplicationParameter("basic-auth-ingress", "project", gcp.kfDef.Spec.Project); err != nil {
 			return errors.WithStack(err)
 		}
+		if err := gcp.kfDef.SetApplicationParameter("istio", "clusterRbacConfig", "OFF"); err != nil {
+			return errors.WithStack(err)
+		}
 	} else {
 		if err := gcp.kfDef.SetApplicationParameter("iap-ingress", "ipName", gcp.kfDef.Spec.IpName); err != nil {
 			return errors.WithStack(err)