Add CSV based env var to define istio hosts Signed-off-by: Josh Harwo…

…od <josh.harwood@thisisbud.com>
kubeflow · Mar 26, 2024 · fb35194 · fb35194
1 parent bd7f250
commit fb35194
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/components/notebook-controller/controllers/notebook_controller.go b/components/notebook-controller/controllers/notebook_controller.go
@@ -496,7 +496,13 @@ func generateVirtualService(instance *v1beta1.Notebook) (*unstructured.Unstructu
 	vsvc.SetKind("VirtualService")
 	vsvc.SetName(virtualServiceName(name, namespace))
 	vsvc.SetNamespace(namespace)
-	if err := unstructured.SetNestedStringSlice(vsvc.Object, []string{"*"}, "spec", "hosts"); err != nil {
+	istioHostsEnv := os.Getenv("ISTIO_HOSTS")
+	if len(istioHostsEnv) == 0 {
+		istioHosts = []string{"*"}
+	} else {
+		istioHosts := strings.Split(istioHostsEnv, ",")
+	}
+	if err := unstructured.SetNestedStringSlice(vsvc.Object, istioHosts, "spec", "hosts"); err != nil {
 		return nil, fmt.Errorf("set .spec.hosts error: %v", err)
 	}