Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapper release instructions need to explain how to build at appropriate commit #1053

Closed
jlewi opened this issue Jun 21, 2018 · 1 comment

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 21, 2018

The bootstrapper release instructions need to explain how to bake the correct version of the repository for our registry into the container image.

https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md

See #1018. for example.

The process should probably look something like the following

  • Build a bootstrapper image that uses the version of the ksonnet registry on the release branch at the commit desired

  • Submit a PR to the release branch updating references to bootstrapper image.

As @pdmack Suggested it might help if we tag our images using RC tags e.g

gcr.io/kubeflow-images-public:0.2.0-rc.0.1

This way we know what the tag will be before the image is built so we don't have to commit a PR after building the image. I think Docker Images have some form of metadata that we could use to store the commit so we know the code from which the images were built.

@jlewi
Copy link
Contributor Author

jlewi commented Aug 10, 2018

We want to stop baking the registry into the bootstrapper image #1155 .

So this issue is obsolete.

@jlewi jlewi closed this as completed Aug 10, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant