Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp] GKE setup; do as much as possible in deploy.sh #1068

Closed
jlewi opened this issue Jun 22, 2018 · 1 comment
Closed

[gcp] GKE setup; do as much as possible in deploy.sh #1068

jlewi opened this issue Jun 22, 2018 · 1 comment
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 22, 2018

Our getting started instructions: https://www.kubeflow.org/docs/started/getting-started-gke/

Depend on a deploy.sh script; but there are still other steps in the process that user has to do manually.
Since we already have deploy.sh; why not move more of the commands into that script and try to infer sensible defaults using gcloud.

Specifically

  1. deploy.sh can download the DM configs

  2. deploy.sh can modify the DM configs

    • Set project and endpoints name
    • Set zone
    • Set email using gcloud auth config list
  3. Create K8s resources including the bootstrapper

    • I think we should stop creating K8s resources with DM
    • We already issue kubectl commands in deploy.sh we might as well move any other resources there
    • Creating K8s resources in DM is weird because you probably don't want to update/manage ks resources using DM
  4. Download the ksonnet app from the bootstrapper

    kubectl cp kubeflow-admin/kubeflow-bootstrapper-0:/opt/bootstrap/default ~/kf-app
    
  5. deploy.sh can create clusterrolebindings to give user necessary K8s permissions

  6. deploy.sh should trigger the creation of KF K8s resource creation (rather than having bootstrapper do this automatically)

    • I think its helpful if a user can see all the steps in deploy.sh
    • Deploy.sh can trigger ks apply doing
    kubectl exec kubeflow-admin kubeflow-bootstrapper-0 cd /opt/bootstrapper/default && ks apply ...
    
    • We can have deploy.sh pass a bearer token to the bootstrapper so bootstrapper doesn't need elevated permissions

/cc @kunmingg @aronchick @ankushagarwal

@jlewi jlewi changed the title [gcp] GKE setup; do as much as possible in setup.sh [gcp] GKE setup; do as much as possible in deploy.sh Jun 22, 2018
@kunmingg
Copy link
Contributor

kunmingg commented Jun 22, 2018

Dependency: #1044

yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
…#1068)

* Fix problem with same time for Trial metric

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants