Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gcp click-to-deploy] Click to deploy web app crashes #1072

Closed
ankushagarwal opened this issue Jun 23, 2018 · 3 comments
Closed

[gcp click-to-deploy] Click to deploy web app crashes #1072

ankushagarwal opened this issue Jun 23, 2018 · 3 comments
Assignees
@jlewi @yebrahim
Labels
priority/p0 problems/bug

Comments

@ankushagarwal
Copy link
Contributor

Repro instructions

cd components/gcp-click-to-deploy
npm install
npm start

# Open web ui

1.hostname: field is not editable
2. Clicking on Create Deployment crashes the web app

image
@ankushagarwal ankushagarwal changed the title [gcp click-to-deploy] Click to deploy crashes [gcp click-to-deploy] Click to deploy web app crashes Jun 23, 2018
@ankushagarwal
Copy link
Contributor Author

/assign @yebrahim

@yebrahim
Copy link
Contributor

The outstanding PR #1054 already fixes this, but it was stuck on failing tests. I'm rerunning them now, will merge if they pass.

@yebrahim
Copy link
Contributor

This shouldn't happen anymore now that the PR is merged, can you confirm and close the issue?

yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@sperlingxx
fix annotations, which crashs custom job (kubeflow#1072)
1388f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlewi jlewi

@yebrahim yebrahim

Labels
priority/p0 problems/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @ankushagarwal @yebrahim