Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TF-Hub to JupyterHub #1223

Closed
activatedgeek opened this issue Jul 16, 2018 · 10 comments
Closed

Rename TF-Hub to JupyterHub #1223

activatedgeek opened this issue Jul 16, 2018 · 10 comments

Comments

@activatedgeek
Copy link
Contributor

This pod's name was a misnomer and should be corrected to avoid confusion with a product by the same name.

@pvsousalima
Copy link
Contributor

pvsousalima commented Jul 16, 2018

I would like to contribute! Would a pod renaming fix it?

@jlewi jlewi added area/0.3.0 area/jupyter Issues related to Jupyter labels Jul 20, 2018
@jlewi
Copy link
Contributor

jlewi commented Aug 6, 2018

@pvsousalima Sorry for the slow reply.

I think what we'd like to do is rename the stateful set.
Specifically in this file
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub.libsonnet#L19

Replace TFHub with JupyterHub

Are you still willing to pick this up?

/assign @pvsousalima

@k8s-ci-robot
Copy link
Contributor

@jlewi: GitHub didn't allow me to assign the following users: pvsousalima.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

@pvsousalima Sorry for the slow reply.

I think what we'd like to do is rename the stateful set.
Specifically in this file
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub.libsonnet#L19

Replace TFHub with JupyterHub

Are you still willing to pick this up?

/assign @pvsousalima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pvsousalima
Copy link
Contributor

Hey @jlewi no problem! Yes, I am!

@jlewi
Copy link
Contributor

jlewi commented Aug 10, 2018

@pvsousalima How's this going?

@pvsousalima
Copy link
Contributor

@jlewi I will open the PR before tomorrow night! I had a flu situation going on here... 👍

@jlewi
Copy link
Contributor

jlewi commented Aug 13, 2018

Thanks. Hope your feeling better.

@jlewi
Copy link
Contributor

jlewi commented Aug 21, 2018

@pvsousalima How's this coming? Do you think you will be able to make progress?

@pvsousalima
Copy link
Contributor

hey @jlewi I am very sorry for such late response, again I got better only yesterday and back to my normal work activities. Yes I will be able to make progress in such. 👍 Will go for the PR today!

@pvsousalima
Copy link
Contributor

pvsousalima commented Aug 24, 2018

@jlewi I have pushed a PR that needs review. I didn't touch the tf-hub-lb, only the Statefulset and its correlated services including headless.

@jlewi jlewi closed this as completed Oct 14, 2018
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
* feat(experiment): Add a check before deletion

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Delete all trials

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: Implement in v1beta1

Signed-off-by: Ce Gao <gaoce@caicloud.io>
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants