Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ksonnet parameter cloud #1227

Closed
jlewi opened this issue Jul 17, 2018 · 5 comments · Fixed by #1742
Closed

Remove ksonnet parameter cloud #1227

jlewi opened this issue Jul 17, 2018 · 5 comments · Fixed by #1742
Assignees
@ashahba
Labels
area/ksonnet Bugs related to ksonnet and prototypes area/0.4.0
Milestone
0.4.0

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 17, 2018

We no longer use the cloud ksonnet parameter so we should just get rid of it.
@jlewi jlewi added priority/p1 area/0.3.0 area/ksonnet Bugs related to ksonnet and prototypes labels Jul 17, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Jul 17, 2018

It looks like we use it in the following places

jupyterhub - cloud is used to set the images. alibaba uses its own registry instead of gcr
ambassador - cloud is used to determine the isDashboardTls parameter

We should probably replace the use of cloud with more direct parameters; e.g. registry in the case of JupyterHub and isDashboardTls for ambassador

@lluunn
Copy link
Contributor

lluunn commented Jul 18, 2018

Also TF serving:
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/tf-serving/tf-serving.libsonnet#L103

@jlewi jlewi removed the priority/p1 label Aug 10, 2018
@ashahba
Copy link
Member

ashahba commented Sep 19, 2018

I can work on this one if not assigned or resolved yet.

@jlewi
Copy link
Contributor Author

jlewi commented Sep 27, 2018

That would be great.

@ashahba
Copy link
Member

ashahba commented Sep 28, 2018

/assign @ashahba

@ashahba ashahba mentioned this issue Oct 10, 2018
Merged
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
@Bobgy
Add Bobgy to tests/OWNERS (kubeflow#1227)
4a5d8f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashahba ashahba

Labels
area/ksonnet Bugs related to ksonnet and prototypes area/0.4.0
Projects
None yet
Milestone
0.4.0
5 participants
@carmine @jlewi @ashahba @lluunn @richardsliu