Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterHub should not open up external IP by default #123

Closed
jlewi opened this issue Jan 16, 2018 · 4 comments
Closed

JupyterHub should not open up external IP by default #123

jlewi opened this issue Jan 16, 2018 · 4 comments
Labels
good first issue
Milestone
Kubecon Europe

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 16, 2018

By default JupyterHub config will open up an external IP address. We should not do that by default since its unsafe.
@jlewi jlewi added this to the Kubecon Europe milestone Jan 16, 2018
@s1113950
Copy link
Contributor

s1113950 commented Feb 8, 2018

I was looking to fix this issue, but am not sure it still exists. I deployed a tf-hub pod via the user guide instructions recently and see this in my pod listing:

tf-hub-0 ClusterIP None <none> 80/TCP 2d which shows no external IP. Maybe I'm missing something?

@lluunn
Copy link
Contributor

lluunn commented Feb 8, 2018

I think it's fixed by #139

@jlewi
Copy link
Contributor Author

jlewi commented Feb 12, 2018

There's a bug #203 that should be fixed by #232.

@jlewi jlewi closed this as completed Mar 7, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Mar 7, 2018

Default is set to ClusterIP here
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/prototypes/all.jsonnet#L12

@jlewi jlewi mentioned this issue Apr 11, 2019
Closed
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@mrkm4ntr @k8s-ci-robot
Fix typo (kubeflow#123)
249152f
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@k8s-ci-robot
Add membership (kubeflow#123)
b987c8e 
Add myself (jxzheng@google.com) as a new member of KFP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
Kubecon Europe
Development

No branches or pull requests
3 participants
@jlewi @s1113950 @lluunn