Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy argo by default; add it to deploy.sh scripts #1268

Closed
lluunn opened this issue Jul 25, 2018 · 4 comments
Closed

Deploy argo by default; add it to deploy.sh scripts #1268

lluunn opened this issue Jul 25, 2018 · 4 comments
Labels
area/0.3.0 platform/gcp

Comments

@lluunn
Copy link
Contributor

lluunn commented Jul 25, 2018

to support pipelines
@jlewi
Copy link
Contributor

jlewi commented Jul 26, 2018

We shouldn't be using deployment manager to install Argo. It should be part of our ksonnet app.

@jlewi jlewi changed the title Deploy argo with deployment manager Deploy argo by default; add it to deploy.sh scripts Jul 26, 2018
@lluunn lluunn mentioned this issue Jul 26, 2018
Merged
@jlewi jlewi reopened this Jul 27, 2018
@jlewi
Copy link
Contributor

jlewi commented Jul 27, 2018

@lluunn looks like you forgot to apply argo in non GKE case.

@lluunn
Copy link
Contributor Author

lluunn commented Jul 27, 2018

Isn't this one: https://github.com/kubeflow/kubeflow/blob/master/scripts/deploy.sh#L72?

@jlewi
Copy link
Contributor

jlewi commented Jul 27, 2018

You're correct; it applies all components.

@jlewi jlewi closed this as completed Jul 27, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@andreyvelich
Add e2e test for DARTS (kubeflow#1268)
c199867 
* Add e2e for darts

* Remove todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/0.3.0 platform/gcp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @lluunn