Update E2E test to use kfctl.sh and delete gke/deploy.sh; #1331
Labels
Comments
|
Updated our tests to use kfctl.sh deploy.sh is still being called by deploy_kubeflow_gcp.sh which is referenced in workflows.jsonnet. I don't think its still being used though; so we could probably just delete it and remove the references. |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this issue
Aug 23, 2018
* These scripts are no longer used to deploy KF on GKE in tests; we now use kfctl. Related to: kubeflow#1331
k8s-ci-robot
pushed a commit
that referenced
this issue
Aug 23, 2018
* These scripts are no longer used to deploy KF on GKE in tests; we now use kfctl. Related to: #1331
|
Post-submit run: Looks like minikube broke because it depends on deploy_kubeflow.py which we deleted in #1406. |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this issue
Aug 24, 2018
* In kubeflow#1406 we deleted deploy_kubeflow.py but this file is still used by the minikube test. * Partially reverts commit a4e4a8e. * Related to kubeflow#1331 * Trigger minikube on presubmits if files used by minikube E2E test are changed. run_e2e_workflow.py uses fnmatch so we can specify individual files or other expressions * Fix kubeflow#1350 trigger minikube test on presubmit when test modified.
k8s-ci-robot
pushed a commit
that referenced
this issue
Aug 29, 2018
* Fix minikube test and trigger on presubmit when modified. * In #1406 we deleted deploy_kubeflow.py but this file is still used by the minikube test. * Partially reverts commit a4e4a8e. * Related to #1331 * Trigger minikube on presubmits if files used by minikube E2E test are changed. run_e2e_workflow.py uses fnmatch so we can specify individual files or other expressions * Fix #1350 trigger minikube test on presubmit when test modified. * * deploy_kubeflow.py should be deploying the v1alpha2 operator of TFJob. * * TFJob simple test should be using v1alpha2. * Update the deploy script to properly wait for the job operator.
|
Post submits are green: |
|
gke/deploy.sh wasn't actually deleted. |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this issue
Sep 5, 2018
k8s-ci-robot
pushed a commit
that referenced
this issue
Sep 5, 2018
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this issue
Feb 11, 2021
* These scripts are no longer used to deploy KF on GKE in tests; we now use kfctl. Related to: kubeflow#1331
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this issue
Feb 11, 2021
) * Fix minikube test and trigger on presubmit when modified. * In kubeflow#1406 we deleted deploy_kubeflow.py but this file is still used by the minikube test. * Partially reverts commit 166dcc2. * Related to kubeflow#1331 * Trigger minikube on presubmits if files used by minikube E2E test are changed. run_e2e_workflow.py uses fnmatch so we can specify individual files or other expressions * Fix kubeflow#1350 trigger minikube test on presubmit when test modified. * * deploy_kubeflow.py should be deploying the v1alpha2 operator of TFJob. * * TFJob simple test should be using v1alpha2. * Update the deploy script to properly wait for the job operator.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this issue
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to delete the deploy.sh scripts
https://github.com/kubeflow/kubeflow/blob/master/scripts/gke/deploy.sh
It is replaced by kfctl.sh
deploy.sh is still being used by our E2E test
https://github.com/kubeflow/kubeflow/blob/master/testing/workflows/components/workflows.jsonnet
We added a new E2E workflow for kfctl.sh
https://github.com/kubeflow/kubeflow/blob/master/testing/workflows/components/kfctl_test.jsonnet
but this test isn't running any validation steps (e.g. running a PyTorch or TFJob test).
Per #1325 we'd like to refactor our tests to make subgraphs/steps more reusable
The text was updated successfully, but these errors were encountered: