Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we modify jupyterhub configuration to use GitHub Authentication? #1585

Closed
gracechristina opened this issue Sep 20, 2018 · 2 comments
Closed
Labels
area/jupyter Issues related to Jupyter kind/question

Comments

@gracechristina
Copy link

gracechristina commented Sep 20, 2018

I would like to modify the configuration of jupyterhub in kubeflow. I want to add OAuth (e.g github). However, I cannot find any guide on how to do so.
The README below mentioned that I need to modify manifest/config.yaml but in the new version of kubeflow, manifest/config.yaml is not available anymore.
https://github.com/kubeflow/kubeflow/tree/v0.2.5/components/jupyterhub
Can somebody help me to point out where can I find any guide on this? It seems that the documentation is not updated and I am really stuck currently. Thank you and looking forward to your replies.

@jlewi jlewi added area/jupyter Issues related to Jupyter kind/question labels Sep 21, 2018
@jlewi
Copy link
Contributor

jlewi commented Sep 21, 2018

/cc @pdmack

@jlewi
Copy link
Contributor

jlewi commented Sep 21, 2018

Here are some guidelines about modifying JupyterHub

The Kube spawner docs for jupyter provide a list of all the options you can configure.

In Kubeflow the Kube spawner Python file is here.

We use the following to easily configure a subset of kubeform spawner optoins

  1. Our JupyterHub ksonnet component takes parameters which are turned into environment variables on the JupyterHub pod.
  2. These environment variables are used in kubeform_spawner.py to set various Jupyter related options

Example attaching extra PVCs

  1. Here's where we set the environment variable based on a ksonnet parameter

value: params.disks,

  1. Here's where that environment variable is turned into jupyter pod options
    pvcs = os.environ.get('KF_PVC_LIST')

So depending on what you need to do to configure GitHub authentication you'll either need to modify the JupyterHub ksonnet component in your app or kubeform_spawner.py.

GitHub authentication with Jupyter isn't well supported at this point; this would be useful to support but it probably needs some love.

Also as this issue describes in Kubeflow we don't want to use JupyterHub for authentication
#11

We have a bunch of webservices (JupyterHub is just one) so we'd like to do authentication in a single service that sits in front of all the individual web services.

So we'd like to do GitHub authentication in a way that will allow secure access to all our webservices not just Jupyter.

It would be amazing to get some community help on this.

@jlewi jlewi changed the title How can we modify jupyterhub configuration? How can we modify jupyterhub configuration to use GitHub Authentication? Sep 21, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
…ubeflow#1585)

* image gcr.io/kubeflow-images-public/xgboost-operator:vmaster-g56c2c075
* Image built from kubeflow/kubeflow@56c2c075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jupyter Issues related to Jupyter kind/question
Projects
None yet
Development

No branches or pull requests

2 participants