Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF data validation and tfma are in 1.9 images but not 1.10 #1718

Closed
jlewi opened this issue Oct 5, 2018 · 5 comments
Closed

TF data validation and tfma are in 1.9 images but not 1.10 #1718

jlewi opened this issue Oct 5, 2018 · 5 comments
Projects
Milestone

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 5, 2018

The imports

failed in
gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu:v0.3.0

but succeeded in
gcr.io/kubeflow-images-public/tensorflow-1.9.0-notebook-cpu:v0.3.0

But we should be installing TFMA in 1.10 as well

@pdmack
Copy link
Member

pdmack commented Oct 8, 2018

Just did a local build and it's there...?

INFO|2018-10-08T15:35:20|build_image.py|46| Successfully built b73b8396f7b2
[root@dell-r730-005 components]# docker run -P -it --rm gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu:latest /bin/bash
root@31a284976789:~# source activate py2
(py2) root@31a284976789:~# pip list | grep tensorflow
tensorflow                         1.10.1
tensorflow-data-validation         0.9.0
tensorflow-metadata                0.9.0
tensorflow-model-analysis          0.9.2
tensorflow-serving-api             1.11.0
tensorflow-transform               0.9.0

@richardsliu
Copy link
Contributor

@jlewi
Copy link
Contributor Author

jlewi commented Oct 9, 2018

Confirmed its not working in a PY2 kernel in

 image: gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu:v0.3.0
    imageID: docker-pullable://gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu@sha256:bd3d2ae9a4e07b2b58910e99a26676ab31f4ba5ae2a633fbde5ce8dee8b63024

notebook

@jlewi
Copy link
Contributor Author

jlewi commented Oct 18, 2018

Postsubmit built the images successfully:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubeflow_kubeflow/kubeflow-postsubmit/822/

Need to retag them 0.3.1 and get them onto the v0.3-branch

@chrisheecho
Copy link

/remove-priority p1
/priority p0

@jlewi jlewi closed this as completed Oct 29, 2018
@chrisheecho chrisheecho added this to Done in 0.4.0 Nov 6, 2018
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.4.0
  
Done
Development

No branches or pull requests

6 participants