Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] download.sh pulls from master instead of based on version tag #1738

Closed
cwbeitel opened this issue Oct 9, 2018 · 2 comments
Closed

Comments

@cwbeitel
Copy link
Contributor

cwbeitel commented Oct 9, 2018

I'm guessing in https://www.kubeflow.org/docs/started/getting-started-gke/ under "Deploy Kubeflow on Kubernetes Engine" the command

curl https://raw.githubusercontent.com/kubeflow/kubeflow/master/scripts/download.sh | bash

was probably meant to be a function of KUBEFLOW_TAG.

cc @sarahmaddox

@cwbeitel
Copy link
Contributor Author

cwbeitel commented Oct 9, 2018

The script does the following at startup

if [ ! -z "${KUBEFLOW_VERSION}" ]; then
	KUBEFLOW_TAG=v${KUBEFLOW_VERSION}
fi

KUBEFLOW_TAG=${KUBEFLOW_TAG:-master}

suggesting the user should set KUBEFLOW_VERSION in their environment before running the script instead of KUBEFLOW_TAG (if the script is to be used as currently written).

@jlewi
Copy link
Contributor

jlewi commented Oct 11, 2018

Thanks @cwbeitel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants