Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version in download.sh #257

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Oct 11, 2018

  • We want to use KUBEFLOW_TAG in the URL so we use the download.sh script
    on the release branch.

Fix kubeflow/kubeflow#1738


This change is Reviewable

* We want to use KUBEFLOW_TAG in the URL so we use the download.sh script
  on the release branch.
@jlewi
Copy link
Contributor Author

jlewi commented Oct 11, 2018

/assign @abhi-g

@jlewi
Copy link
Contributor Author

jlewi commented Oct 11, 2018

/assign @cwbeitel

Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4ed42eb into kubeflow:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants