New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a repository for examples: kubeflow/examples #174
Comments
@jlewi Why do you think we need a separate repo and not Kubeflow be that place? |
I have some additional examples in progress to add. Would love to have them under e2e test. But for some examples you may want to do progressive testing to speed things up / cache previous runs. Such as with Bazel. That could be a mod to the way kubeflow runs tests or could be a reason to have a separate repo. |
@puneith Because examples will be in various states of development and should probably be separate from the core code. For the most part, this repo corresponds to our ksonnet registry. |
Another reason for moving examples into their own repository is that it will probably be a different group of folks working on the examples then the folks working on our core ksonnet components. |
I agree with that model. |
Vote for separate repo 👍 |
I could go either way, but my doc fixes have included ksonnet changes. Managing two separate repos for things that are tied together may be painful. |
@elsonrodriguez I think the fact that writing examples requires modifying our core ksonnet components is an indication of other problems
|
Lets give a separate repo a shot and then adapt as need be. I think the main priority now is getting more examples that illustrate Kubeflow so velocity is the primary motivation. With a separate repo we can easily start giving a different set of folks write access and moving the ball forward. @elsonrodriguez If you want to take the lead on an inception example I'm happy to make you an approver. |
Created the repo: Created a team examples-approvers and gave it write access to the repo. |
@jlewi Sure, I can take the current inception example and rework/port it over. |
* Run helm convert on the current sparkoperator from GCP folks (not GCP specific) * Try and put the spark operator in the kubeflow namespace * Move the spark operator into base/ and generate a sample test * is crd not crb * Attempt to address CR feedback * use the nameprefix instead of having sparkoperator- everywhere * Update the spark test to match the changes * move spark-operator to spark * move base into spark-operator subdir * Update spark operator test * Add the appplication overlay
…eflow#174) * Related to kubeflow#141 katib releaser * Related to kubeflow#1574 use prow to build our images * We are moving to using prow to run our release workflows and treating them just like regular workflows. * We are doing this because we need to get regular signal about whether the image builds are succeeding by running on postsubmit. * We also want to run them on presubmit so that we can verify any changes to the workflwo don't break the workflow. * Rather than define a new workflow to build the images; we can just reuse the existing E2E workflow which already builds all the images. We just change postsubmit to push to kubeflow-images-public. * Delete the releaser app; we will just the existing E2E test workflow and have that push to gcr.io/kubeflow-images-public on postsubmit.
* Include me as viewer * Alphabetical ordering
I think we should create a repository where we can start hosting E2E examples.
Right now we have a couple E2E examples in various states of development
/cc @puneith @cwbeitel
The text was updated successfully, but these errors were encountered: