Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures #176

Closed
jlewi opened this issue Jan 30, 2018 · 2 comments
Closed

Test failures #176

jlewi opened this issue Jan 30, 2018 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 30, 2018

Tests are failing

Error updating customresourcedefinitions tfjobs.tensorflow.org: CustomResourceDefinition.apiextensions.k8s.io "tfjobs.tensorflow.org" is invalid: spec.names.
kind: Invalid value: "TFJob": field is immutable

I think this is because we changed the name from TfJob to TFJob but we are reusing the same K8s test cluster in which the CRD is defined. So we probably just need to delete it.

@jlewi
Copy link
Contributor Author

jlewi commented Jan 30, 2018

Here's the value of the CRD on the cluster.

kubectl get crd -o yaml tfjobs.tensorflow.org
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: 2018-01-18T02:18:19Z
  generation: 1
  name: tfjobs.tensorflow.org
  resourceVersion: "2491718"
  selfLink: /apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/tfjobs.tensorflow.org
  uid: d98de85c-fbf5-11e7-bf40-42010af000a6
spec:
  group: tensorflow.org
  names:
    kind: TfJob
    listKind: TfJobList
    plural: tfjobs
    singular: tfjob
  scope: Namespaced
  version: v1alpha1
status:
  acceptedNames:
    kind: TfJob
    listKind: TfJobList
    plural: tfjobs
    singular: tfjob
  conditions:
  - lastTransitionTime: null
    message: no conflicts found
    reason: NoConflicts
    status: "True"
    type: NamesAccepted
  - lastTransitionTime: 2018-01-18T02:18:19Z
    message: the initial names have been accepted
    reason: InitialNamesAccepted
    status: "True"
    type: Established

So lets delete it.

kubectl delete crd tfjobs.tensorflow.org

@jlewi
Copy link
Contributor Author

jlewi commented Jan 30, 2018

We may need to update the image for the operator to use a Docker image built after the change.

@jlewi jlewi closed this as completed Feb 27, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
* update vendors

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* add retain flags to study job controller

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix vendor

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix unchange status

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* add handling for failed status

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant