Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to build from source: Makefile:17: recipe for target 'presubmit' failed #1812

Closed
tech509201941 opened this issue Oct 17, 2018 · 7 comments
Assignees

Comments

@tech509201941
Copy link

I want to build kubeflow from source and deploy it in a container.
I used the setup instructions from over here:
https://www.kubeflow.org/docs/started/getting-started/

This is my docker container:

FROM ubuntu:16.04

ARG DOCKER_HOST=tcp://localhost:2375

RUN apt-get update
RUN apt-get install sudo
RUN sudo apt-get install -y curl gnupg apt-transport-https ca-certificates software-properties-common curl git bash make python wget autoconf

COPY . /usr/src/app
WORKDIR /usr/src/app
RUN ls

RUN wget https://dl.google.com/go/go1.11.1.linux-amd64.tar.gz && tar xvfz go1.11.1.linux-amd64.tar.gz && sudo chown -R root:root ./go && sudo mv go /usr/local && . env/.profile && . env/.bash_profile

RUN cd .. && chmod -R +x app && cd app
RUN make && sudo make install

RUN bash

RUN ./scripts/kfctl.sh init kfapp_config --platform none
RUN ./scripts/kfctl.sh generate k8s
RUN ./scripts/kfctl.sh apply k8s

Everythings works except the "RUN make && sudo make install" part.
It fails with:

(...)
Boilerplate header is wrong for: /usr/src/app/bootstrap/cmd/bootstrap/app/options/options.go
Boilerplate header is wrong for: /usr/src/app/bootstrap/version/version.go
Makefile:17: recipe for target 'presubmit' failed
make: *** [presubmit] Error 1
The command '/bin/sh -c make && sudo make install' returned a non-zero code: 2
ERROR: Job failed: error executing remote command: command terminated with non-zero exit code: Error executing in Docker Container: 1

If I skip the making of the source, I encounter the following error at the part "RUN ./scripts/kfctl.sh init kfapp_config --platform none":

(...)
+ check_install ks
+ which ks
+ echo 'You don'\''t have ks installed. Please install ks.'
You don't have ks installed. Please install ks.
+ exit 1
The command '/bin/sh -c ./scripts/kfctl.sh init kfapp_config --platform none' returned a non-zero code: 1
ERROR: Job failed: error executing remote command: command terminated with non-zero exit code: Error executing in Docker Container: 1

Does anyone has an idea on how to address this issue?
Thanks a lot :)

@r2d4
Copy link
Member

r2d4 commented Oct 17, 2018

Are you running https://github.com/kubeflow/kubeflow/blob/master/Makefile?

all: presubmit

presubmit:
	@echo ">> checking file boilerplate"
	@./build/check_boilerplate.sh

TAG?=$(shell git rev-parse HEAD)
.PHONY: all presubmit

This is only running the boilerplate check and not used anywhere AFAIK. It should be safe to remove.

@r2d4
Copy link
Member

r2d4 commented Oct 17, 2018

/assign @r2d4

@tech509201941
Copy link
Author

Hi r2d4,

you're right, I am trying to build from source on basis of the makefile that is provided within the official github repo.

Unfortunately, I already tried to skip the make install process step but than occurs this error:

(...)
+ check_install ks
+ which ks
+ echo 'You don'\''t have ks installed. Please install ks.'
You don't have ks installed. Please install ks.
+ exit 1
The command '/bin/sh -c ./scripts/kfctl.sh init kfapp_config --platform none' returned a non-zero code: 1
ERROR: Job failed: error executing remote command: command terminated with non-zero exit code: Error executing in Docker Container: 1

So how do I install "ks "without building it via the makefile?
Thanks a lot :)

@r2d4
Copy link
Member

r2d4 commented Oct 17, 2018

ks is the ksonnet binary. You can download it from their release page. https://github.com/ksonnet/ksonnet/releases/tag/v0.11.0

ksonnet is a requirement for generating the configuration for deploying the kubeflow cluster.

@jlewi
Copy link
Contributor

jlewi commented Oct 18, 2018

@tech509201941 What do you mean by build Kubeflow from source and run in a container.

Kubeflow is a collection of microservices deployed on Kubernetes. Running those microservices in a single container is not supported.

@r2d4
Copy link
Member

r2d4 commented Jan 7, 2019

/close

The makefile was removed, you should use kfctl.sh.

@k8s-ci-robot
Copy link
Contributor

@r2d4: Closing this issue.

In response to this:

/close

The makefile was removed, you should use kfctl.sh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants