Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksonnet namespace should be retrieved from env not params #1825

Closed
kkasravi opened this issue Oct 19, 2018 · 0 comments · Fixed by #1829
Closed

ksonnet namespace should be retrieved from env not params #1825

kkasravi opened this issue Oct 19, 2018 · 0 comments · Fixed by #1829

Comments

@kkasravi
Copy link
Contributor

having it in both is confusing and error prone. Remove the anachronistic usage of params.namespace which came about when namespace wasn't being correctly propagated in earlier versions of ksonnet.
This was referenced Oct 19, 2018
Merged
Merged
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
@pvaneck
Add Kubeflow overlay to Feast (kubeflow#1825)
3df9eca 
In order to make the Feast manifests installable as
both standalone and as a part of Kubeflow, the base install
will continue to use the 'feast' namespace and the 'kubeflow'
overlay can be used for those looking to use Feast with Kubeflow.

Signed-off-by: Paul Van Eck <pvaneck@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes 'ksonnet namespace should be retrieved from env not params' kkasravi/kubeflow
1 participant
@kkasravi