Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: include 'google-api-python-client' in the JH images #1932

Closed
amygdala opened this issue Nov 9, 2018 · 2 comments
Closed

feature request: include 'google-api-python-client' in the JH images #1932

amygdala opened this issue Nov 9, 2018 · 2 comments
Labels
area/jupyter Issues related to Jupyter good first issue help wanted

Comments

@amygdala
Copy link
Contributor

amygdala commented Nov 9, 2018

It would be useful to bundle the google-api-python-client lib in the JupyterHub images.
E.g. for writing scripts that connect to GCP products like CMLE.
@jlewi
Copy link
Contributor

jlewi commented Dec 27, 2018

We do install the newer google-cloud library

kubeflow/components/tensorflow-notebook-image/requirements.txt

Line 18 in bf94de1

google-cloud

@svalleru svalleru mentioned this issue Jan 8, 2019
Merged
Ema93sh added a commit to Ema93sh/kubeflow that referenced this issue Jan 13, 2019
@Ema93sh
Added 'google-api-python-client' to the jupyterhub image
4e353e7 
This commit fixes issue (kubeflow#1932)
@Ema93sh Ema93sh mentioned this issue Jan 13, 2019
Closed
@lluunn
Copy link
Contributor

lluunn commented Jan 15, 2019

Do you mean adding to notebook images?
Hub doesn't need to do anything other than spawning notebook I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jupyter Issues related to Jupyter good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amygdala @jlewi @lluunn