Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook manager UI should disable New PVC option if no default storage class is defined. #2157

Closed
jlewi opened this issue Dec 21, 2018 · 5 comments · Fixed by #2679
Closed
Assignees
Labels
area/jupyter Issues related to Jupyter priority/p1
Projects

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 21, 2018

Context: #2155

Creating a PVC to back Jupyter pods can be a major friction point for new users just kicking the tires.

As #2155 shows users may not realize they can just disable PVC.

We can configure kfctl to test if a cluster has a default storage class and if not disable the use of PVC with jupyter by default.

@jlewi jlewi added this to New in 0.5.0 via automation Dec 21, 2018
@jlewi jlewi moved this from New to Deploy Kubeflow in 0.5.0 Dec 26, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Feb 21, 2019

Rather than doing this in kfctl; perhaps we should just do this in the jupyter spawner app?

@jlewi
Copy link
Contributor Author

jlewi commented Feb 21, 2019

according to @vkoukis, @kimwnasptd might already have implemented this in the new web app.

@kimwnasptd
Copy link
Member

The webapp provides a warning only when the user chooses to not use a PVC. It doesn't currently take any action based on storage class.

I think we should check if a default storage class is set. If not, then don't allow users to create new PVCs, but allow them to use existing ones.

What do you think @jlewi ?

@jlewi
Copy link
Contributor Author

jlewi commented Mar 4, 2019

@kimwnasptd I think that makes sense.

I'm going to move this to 0.6 because we already have too many issues in 0.5

@jlewi jlewi added this to New in 0.6.0 via automation Mar 4, 2019
@jlewi jlewi removed this from Deploy Kubeflow in 0.5.0 Mar 4, 2019
@jlewi jlewi changed the title kfctl should disable durable storage if no default storage class is defined Notebook manager UI should disable New PVC option if no default storage class is defined. Mar 4, 2019
@kimwnasptd
Copy link
Member

ACK, although it shouldn't be a large one so I'll try to make a PR in the next days
/assign kimwnasptd

surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jupyter Issues related to Jupyter priority/p1
Projects
No open projects
0.6.0
  
New
Development

Successfully merging a pull request may close this issue.

2 participants