New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook manager UI should disable New PVC option if no default storage class is defined. #2157
Comments
Rather than doing this in kfctl; perhaps we should just do this in the jupyter spawner app? |
according to @vkoukis, @kimwnasptd might already have implemented this in the new web app. |
The webapp provides a warning only when the user chooses to not use a PVC. It doesn't currently take any action based on storage class. I think we should check if a default storage class is set. If not, then don't allow users to create new PVCs, but allow them to use existing ones. What do you think @jlewi ? |
@kimwnasptd I think that makes sense. I'm going to move this to 0.6 because we already have too many issues in 0.5 |
ACK, although it shouldn't be a large one so I'll try to make a PR in the next days |
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Context: #2155
Creating a PVC to back Jupyter pods can be a major friction point for new users just kicking the tires.
As #2155 shows users may not realize they can just disable PVC.
We can configure kfctl to test if a cluster has a default storage class and if not disable the use of PVC with jupyter by default.
The text was updated successfully, but these errors were encountered: