Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter CR E2E test #2174

Closed
jlewi opened this issue Dec 26, 2018 · 1 comment
Closed

Jupyter CR E2E test #2174

jlewi opened this issue Dec 26, 2018 · 1 comment
Labels
area/jupyter Issues related to Jupyter area/testing cuj/multi-user priority/p1
Projects
0.5.0

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 26, 2018

Context: http://bit.ly/kf_jupyter_design_doc

We will need an E2E test for our the Jupyter custom resource.
@jlewi jlewi added this to New in 0.5.0 via automation Dec 26, 2018
@jlewi jlewi moved this from New to Multi-user kubeflow in 0.5.0 Dec 26, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Jan 22, 2019

I'll take a stab at this.

I think there's a couple pieces to this

  1. We should modify kfctl.sh to install the Jupyter CR by default
  2. We should create a python program to act as an E2E test that verifies we can create a notebook
    resource.

I will get started on the second item.

jlewi added a commit to jlewi/kubeflow that referenced this issue Jan 23, 2019
@jlewi
Create an E2E test for the Jupyter custom resource.
a1ac4ca 
* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to kubeflow#2174 - E2E test for Jupyter CR.
jlewi added a commit to jlewi/kubeflow that referenced this issue Jan 24, 2019
@jlewi
Create an E2E test for the Jupyter custom resource.
10cea7c 
* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to kubeflow#2174 - E2E test for Jupyter
@jlewi jlewi mentioned this issue Jan 24, 2019
Merged
jlewi added a commit to jlewi/kubeflow that referenced this issue Jan 25, 2019
@jlewi
Create an E2E test for the Jupyter custom resource.
72aba2a 
* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to kubeflow#2174 - E2E test for Jupyter
@jlewi jlewi mentioned this issue Jan 25, 2019
Merged
k8s-ci-robot pushed a commit that referenced this issue Jan 29, 2019
@jlewi @k8s-ci-robot
Create an E2E test for the Jupyter custom resource. (#2323)
2fb6bcf 
* Create an E2E test for the Jupyter custom resource.

* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to #2174 - E2E test for Jupyter

* Exclude the test app directory.

* Address reviewer comments.
@kimwnasptd kimwnasptd mentioned this issue Jan 31, 2019
Merged
0.5.0 automation moved this from Multi-user kubeflow to Done Feb 1, 2019
kkasravi pushed a commit to kkasravi/kubeflow that referenced this issue Feb 8, 2019
@jlewi
Create an E2E test for the Jupyter custom resource. (kubeflow#2323)
c99a709 
* Create an E2E test for the Jupyter custom resource.

* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to kubeflow#2174 - E2E test for Jupyter

* Exclude the test app directory.

* Address reviewer comments.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
@jlewi @k8s-ci-robot
Create an E2E test for the Jupyter custom resource. (kubeflow#2323)
d303915 
* Create an E2E test for the Jupyter custom resource.

* Create a ksonnet test app to contain the manifests for the Jupyter notebook

  * We already have pretty good test utilities for creating ksonnet components
    so we might as well leverage that rather than using raw YAMl
    and trying to parameterize it.

* jupyter_test.py is the E2E test written using pytest;

  * It is currently a manual test. In a follow on PR we will integrate it
    into the E2E test workflow.

Related to kubeflow#2174 - E2E test for Jupyter

* Exclude the test app directory.

* Address reviewer comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jupyter Issues related to Jupyter area/testing cuj/multi-user priority/p1
Projects
No open projects
0.5.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi