Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jupyter images to work with the new jupyter CR #2458

Closed
jlewi opened this issue Feb 12, 2019 · 7 comments
Closed

Change jupyter images to work with the new jupyter CR #2458

jlewi opened this issue Feb 12, 2019 · 7 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 12, 2019

See discussion in #2456

We are waiting on a resolution to #2456 but some things to consider

  1. Per discussion in Issues with the current Go notebook controller #2456 we may want to encode an entrypoint and args in the Dockerfile so they don't need to be specified in the Jupyter CR

/cc @zabbasi

@jlewi jlewi added this to New in 0.5.0 via automation Feb 12, 2019
@jlewi jlewi moved this from New to Mid Release Demo in 0.5.0 Feb 14, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Feb 19, 2019

/assign @zabbasi

@k8s-ci-robot
Copy link
Contributor

@jlewi: GitHub didn't allow me to assign the following users: zabbasi.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zabbasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ioandr
Copy link
Contributor

ioandr commented Feb 19, 2019

Any update on this?

@abhi-g
Copy link
Member

abhi-g commented Feb 19, 2019

/assign @zabbasi

@zabbasi
Copy link
Contributor

zabbasi commented Mar 4, 2019

addressed in the following PRs:
#2611
#2606
#2591
#2517

@zabbasi
Copy link
Contributor

zabbasi commented Mar 4, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@zabbasi: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0.5.0 automation moved this from Mid Release Demo to Done Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.5.0
  
Done
Development

No branches or pull requests

5 participants