Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow jobs should use a common docker image #276

Closed
jlewi opened this issue Feb 21, 2018 · 2 comments
Closed

Prow jobs should use a common docker image #276

jlewi opened this issue Feb 21, 2018 · 2 comments
Assignees
@lluunn
Labels
area/testing

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 21, 2018

Right now kubeflow/kubeflow builds a custom Docker image for use in its prow jobs.
https://github.com/kubeflow/kubeflow/tree/master/testing

That shouldn't be necessary once we start using a prow_config.yaml file in the repository to configure the workflows to run.

At that point we can just use the docker image built in kubeflow/testing
https://github.com/kubeflow/testing/tree/master/images

For this to work we will need to update our prow jobs in kubernetes/test-infra
https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml#L261

Currently our jobs for kubeflow/kubeflow use
gcr.io/mlkube-testing/kubeflow-testing:latest

We should change that to
gcr.io/kubeflow-ci/test-worker:latest
This was referenced Feb 21, 2018
Closed
Merged
Merged
jlewi pushed a commit that referenced this issue Feb 22, 2018
@lluunn @jlewi
add prow_config.yaml (#271)
bd44e4b 
prow_config.yaml contains the workflows that we want to run by prow.

By using prow_config.yaml, we can use the same testing image for different kubeflow repos.

Related to #276
@lluunn lluunn mentioned this issue Feb 22, 2018
Merged
@jlewi
Copy link
Contributor Author

jlewi commented Feb 27, 2018

All our tests are now using the same image.

We just need to delete the code for the old image here
https://github.com/kubeflow/kubeflow/tree/master/testing

jlewi added a commit to jlewi/k8s that referenced this issue Mar 1, 2018
@jlewi
Delete Dockerfile to build a docker image to use for proow.
73730ca 
* All repositories use a common image now.
* We no longer need this image.

Related to:

kubeflow/kubeflow#276
@jlewi jlewi mentioned this issue Mar 1, 2018
Merged
jlewi added a commit to kubeflow/training-operator that referenced this issue Mar 1, 2018
@jlewi
Delete Dockerfile to build a docker image to use for proow. (#425)
2459f1c 
* All repositories use a common image now.
* We no longer need this image.

Related to:

kubeflow/kubeflow#276
jimexist pushed a commit to jimexist/tf-operator that referenced this issue Mar 7, 2018
@jlewi
Delete Dockerfile to build a docker image to use for proow. (kubeflow…
22ea9bd 
…#425)

* All repositories use a common image now.
* We no longer need this image.

Related to:

kubeflow/kubeflow#276
@jlewi
Copy link
Contributor Author

jlewi commented Mar 26, 2018

Fixed.

@jlewi jlewi closed this as completed Mar 26, 2018
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@harshad16
Add harshad16 to kubeflow ci-team (kubeflow#276)
7a6a122 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lluunn lluunn

Labels
area/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @lluunn