Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFServing docs are incorrect; we no longer assign a public IP by default #296

Closed
jlewi opened this issue Feb 25, 2018 · 3 comments
Closed

TFServing docs are incorrect; we no longer assign a public IP by default #296

jlewi opened this issue Feb 25, 2018 · 3 comments
Labels
area/docs area/inference good first issue help wanted priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 25, 2018

The docs:
https://github.com/kubeflow/kubeflow/blob/master/user_guide.md#serve-a-model

Incorrectly describe using an external IP for the model.

But by default we don't serve models on external IP addresses. We also don't currently have an option to easily allow that (#295).

We should update the docs and tell users
@fxue
Copy link
Contributor

fxue commented Feb 27, 2018

I will work on this once PR for #295 is merged.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 7, 2018

@fxue #295 is merged. Can we update the docs?

@jlewi
Copy link
Contributor Author

jlewi commented Mar 7, 2018

Duplicate of #233

@jlewi jlewi marked this as a duplicate of #233 Mar 7, 2018
@jlewi jlewi closed this as completed Mar 7, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@hougangliu @k8s-ci-robot
reduce some redundant code (kubeflow#296)
07e0fd2
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@StefanoFioravanzo
Add StefanoFioravanzo to Kubeflow org (kubeflow#296)
0cc2658 
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs area/inference good first issue help wanted priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @fxue